-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc #6209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbeekman
changed the title
Mpi blas doc update
Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc
Jun 4, 2019
tschoonj
reviewed
Jun 5, 2019
MikeMcQuaid
requested changes
Jun 5, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change otherwise 👍
zbeekman
force-pushed
the
MPI-BLAS-doc-update
branch
from
June 5, 2019 18:06
957f382
to
8ff8078
Compare
zbeekman
commented
Jun 5, 2019
zbeekman
commented
Jun 5, 2019
zbeekman
changed the title
Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc
Update documentation & cops to codify MPI and BLAS/LAPACK library choices & link rubydoc
Jun 5, 2019
zbeekman
commented
Jun 5, 2019
@@ -50,6 +50,7 @@ | |||
- [Brew Test Bot For Maintainers](Brew-Test-Bot-For-Core-Contributors.md) | |||
- [Common Issues for Maintainers](Common-Issues-for-Core-Contributors.md) | |||
- [Releases](Releases.md) | |||
- [Developer/Internal API Documentation](https://rubydoc.brew.sh) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I renamed this to avoid confusion with more public facing APIs like formulae.brew.sh
reitermarkus
reviewed
Jun 5, 2019
MikeMcQuaid
reviewed
Jun 6, 2019
zbeekman
force-pushed
the
MPI-BLAS-doc-update
branch
from
June 6, 2019 15:23
0a5480e
to
68288b3
Compare
zbeekman
changed the title
Update documentation & cops to codify MPI and BLAS/LAPACK library choices & link rubydoc
Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc
Jun 6, 2019
zbeekman
changed the title
Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc
Ready: Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc
Jun 6, 2019
zbeekman
added a commit
to zbeekman/brew
that referenced
this pull request
Jun 6, 2019
- Split off from PR Homebrew#6209 - Create stand alone class for cop w/ auto-correct
MikeMcQuaid
changed the title
Ready: Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc
Update documentation to codify MPI and BLAS/LAPACK library choices & link rubydoc
Jun 7, 2019
MikeMcQuaid
approved these changes
Jun 7, 2019
Thanks @zbeekman! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew style
with your changes locally?brew tests
with your changes locally?Explanation of changes:
All documentation changes.
Formalize:
Add a link to https://rubydoc.brew.sh to https://docs.brew.sh because I'm a derp and can never remember where it is. Also, it would be good to start getting the up-to-date developer documentation higher in search rankings than the old outdated version.